Add support for Apple Silicon#201
Merged
Merged
Conversation
|
Works for me for doing native builds in ROS 2, and this one is a bit cleaner than my quick fix at osrf/osrf_testing_tools_cpp#62 Any chance of it getting merged quickly so we can merge it into the ROS 2 one? |
Owner
|
Thanks! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #200.
When compiling on Apple Silicon at commit
27a8900, the following build error is produced:This is caused by
__aarch64__being defined on Apple Silicon, however is incorrect for assigning the error address.A conditional to check for
__APPLE__was added to the__aarch64__#ifdef case with the appropriate error address cast.All tests pass when compiling for
ARM64and Universal 2, ran on an M1 Mac (bothARM64and Universal 2 binaries) and an Intel Mac.