test: include #1439 in test set and clean up of related issues

[barendgehrels]

No description provided.

[tinko92]

Looks good to me based on reading the diff. Because I have many unrelated test failures on my current machine, I did not test locally and trust the CI on this (since it only touches ./test/ anyway).

The comment on overlay.cpp is helpful, I was unsure about it's relationship to set_ops_areal_areal.cpp during earlier work. As an aside, is there any significance to some of its tests being commented out rather than behind BOOST_GEOMETRY_TEST_FAILURES?

[barendgehrels]

Looks good to me based on reading the diff. Because I have many unrelated test failures on my current machine, I did not test locally and trust the CI on this (since it only touches ./test/ anyway).

The comment on overlay.cpp is helpful, I was unsure about it's relationship to set_ops_areal_areal.cpp during earlier work. As an aside, is there any significance to some of its tests being commented out rather than behind BOOST_GEOMETRY_TEST_FAILURES?

Thanks for the approval and the comment!

Indeed, overlay.cpp is mostly a debugging tool and has the visuals I need. Mainly we should (ever) move it outside the unit tests... The cases tested are usually duplicate. They can just go.

There is also a buffer_overlay.cpp with the same purpose.

And yes, tests are commented out - they could actually just be removed from these two sources.

[barendgehrels]

Taking the freedom to merge also this, it's test only and has an approval