Skip to content

[test] update testsuite - #723

Merged
barendgehrels merged 1 commit into
boostorg:developfrom
barendgehrels:test/mark_failures
Jun 24, 2020
Merged

[test] update testsuite#723
barendgehrels merged 1 commit into
boostorg:developfrom
barendgehrels:test/mark_failures

Conversation

@barendgehrels

@barendgehrels barendgehrels commented Jun 10, 2020

Copy link
Copy Markdown
Collaborator
  • some cases are fixed in the meantime, this is updated
  • in difference there might be slivers which are still OK, therefore an count_set is used there
  • when BOOST_GEOMETRY_TEST_FAILURES is defined, it also writes expected failures - this makes it much easier to detect improvements (or regressions)
  • this also shows insight in the current state, which is more or less in par with the rescaling - this means we might switch in next release (and one or two releases later remove the rescaling code)

… enabled),

use optional counts for difference tests.

@vissarion vissarion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks ok to me.

@barendgehrels
barendgehrels merged commit 3b3c6d3 into boostorg:develop Jun 24, 2020
@barendgehrels
barendgehrels deleted the test/mark_failures branch June 24, 2020 09:15
@barendgehrels

Copy link
Copy Markdown
Collaborator Author

Merged, assuming no objections, and next PR is to built on top of this one.
If there are still considerations, let me know.

@awulkiew awulkiew added this to the 1.74 milestone Oct 15, 2020
@awulkiew awulkiew added the tests label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants