Fix/traversal cluster exits - #732
Merged
barendgehrels merged 2 commits intoJul 1, 2020
Merged
Conversation
barendgehrels
commented
Jun 24, 2020
barendgehrels
commented
Collaborator
- Fix some cases in buffer which went wrong without rescaling
- Therefore extracted cluster_exits functionality (was already there, but in traversal. Now in external file)
- Clean up some defines in robustness test and write test configuration
This makes it more efficient too (sort-by-side one time less). This fixes some cases in buffer when rescaling is turned off.
barendgehrels
commented
Jun 24, 2020
| // Function checks simple cases, such as a cluster with two turns, | ||
| // arriving at the first turn, first turn points to second turn, | ||
| // second turn points further. | ||
| inline bool select_turn_from_cluster_linked(signed_size_type& turn_index, |
Collaborator
Author
There was a problem hiding this comment.
this functionality is now moved to cluster_exit, a struct is made, and there is one additional condition (the fix)
barendgehrels
commented
Jun 24, 2020
|
|
||
| #if defined(BOOST_GEOMETRY_TEST_FAILURES) | ||
| BoostGeometryWriteExpectedFailures(1, 9); | ||
| BoostGeometryWriteExpectedFailures(1, 5); |
Collaborator
Author
There was a problem hiding this comment.
It effectively fixes 2 cases
awulkiew
approved these changes
Jul 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.