Skip to content

Conversation

@tleb
Copy link
Member

@tleb tleb commented Oct 29, 2025

Sometimes you want to build-test all training content once you modified some slides. Add PHONY targets:

⟩ # generate slides/labs/agendas/tarballs for all three variants 
⟩ make linux-kernel
⟩
⟩ # same thing for the audio training:
⟩ #   full-audio-slides.pdf audio-agenda.pdf audio-fr-agenda.pdf
⟩ #   audio-online-agenda.pdf audio-online-fr-agenda.pdf
⟩ make audio

Sometimes you want to build-test all training content once you modified
some slides. Add PHONY targets:

⟩ # generate slides/labs/agendas/tarballs for all three variants
⟩ make linux-kernel
⟩
⟩ # same thing for the audio training:
⟩ #   full-audio-slides.pdf audio-agenda.pdf audio-fr-agenda.pdf
⟩ #   audio-online-agenda.pdf audio-online-fr-agenda.pdf
⟩ make audio

Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
@tleb
Copy link
Member Author

tleb commented Oct 30, 2025

Just to clarify: I created this pull request to ask for feedback rather than push directly. I am not certain everyone agrees with the change (even though I don't see many cons to it).

Copy link
Contributor

@Tropicao Tropicao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tleb , I agree with the change, and I like it, from a trainer POV

@tleb
Copy link
Member Author

tleb commented Nov 4, 2025

Thanks for the review @Tropicao! I would like parallel compilation of agendas to be working before we merge this. Mostly a selfish desire because my system has MAKEFLAGS=-j20 globally. :-) Agendas look like the only place where our parallel compilation is broken, see #268 (comment)

@Tropicao
Copy link
Contributor

Tropicao commented Dec 3, 2025

Hi @tleb,
I am still pretty interested in getting your PR merged. You mentioned that you would like parallel build fix merged first, but it looks stalled. I also fail to see a hard requirement between the two PRs. If they are not indeed tightly coupled, can we move forward with this one ?

@tleb
Copy link
Member Author

tleb commented Dec 3, 2025

My comment above explains why I was interested in fixing parallel builds first: I do parallel builds by default because I have MAKEFLAGS=-j19 set globally. Anyway we can merge the patch to avoid keeping it stalled

@tleb tleb merged commit f2f3eb3 into bootlin:master Dec 3, 2025
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants