Python script for hybrid inference on City10000 dataset#2019
Merged
varunagrawal merged 21 commits intodevelopfrom Feb 9, 2025
Merged
Python script for hybrid inference on City10000 dataset#2019varunagrawal merged 21 commits intodevelopfrom
varunagrawal merged 21 commits intodevelopfrom
Conversation
dellaert
approved these changes
Feb 9, 2025
Member
dellaert
left a comment
dellaert
left a comment
There was a problem hiding this comment.
Cool. I’d undo the std::move changes though. Just adding. Constructor should low you to wrap.
examples/Hybrid_City10000.cpp
Outdated
| HybridValues delta = bayesNet->optimize(); | ||
| initial_ = initial_.retract(delta.continuous()); | ||
| smoother_.reInitialize(std::move(*bayesNet)); | ||
| smoother_.reInitialize(*bayesNet); |
gtsam/hybrid/HybridSmoother.h
Outdated
| */ | ||
| void reInitialize(HybridBayesNet&& hybridBayesNet) { | ||
| hybridBayesNet_ = std::move(hybridBayesNet); | ||
| void reInitialize(HybridBayesNet& hybridBayesNet) { |
Member
There was a problem hiding this comment.
Just add another non && constructor rather than deleting this one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapped a bunch of methods and recreated the script
Hybrid_City10000.cppasHybridCity10000.py.I get a similar final error:
Final error: 0.6931471805599453and a similar total time:
Total time: 21.018189191818237 secondsPlease see the results of this new script below.
Update: I added a python script for plotting the results. It takes an arbitrary number of estimate files (.txt) but needs a corresponding number of labels and colors associated.