Fix MATLAB matrix view size check#185
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a dimension-range guard in the MATLAB unwrapMatrixView path by avoiding a potentially narrowing cast to mwSize before comparing against Eigen::Index limits, and updates the wrapper test to assert the new widened comparison logic.
Changes:
- Update
unwrapMatrixViewto comparerows/colsandEigen::Index::max()using a widened unsigned integer type before casting toEigen::Index. - Keep the no-copy matrix-view unwrap path compatible with builds where
mwSizemay be 32-bit (e.g.,MX_COMPAT_32scenarios). - Add a unit test assertion that the generated header contains the widened rows cast used in the guard.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
matlab.h |
Widen the dimension guard comparisons for rows/cols vs Eigen::Index max before casting to Eigen::Index. |
tests/test_matlab_wrapper.py |
Assert presence of the widened cast in the generated/checked header content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation