Skip to content

Fix MATLAB matrix view size check #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dellaert merged 1 commit into from
May 26, 2026
Merged

Fix MATLAB matrix view size check #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions matlab.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,8 +436,10 @@ MatrixView unwrapMatrixView(const mxArray* array) {
if (mxIsDouble(array)==false || mxIsComplex(array) || mxIsSparse(array))
error("unwrapMatrixView: not a full real double matrix");
const mwSize rows = mxGetM(array), cols = mxGetN(array);
if (rows > static_cast<mwSize>(std::numeric_limits<Eigen::Index>::max()) ||
cols > static_cast<mwSize>(std::numeric_limits<Eigen::Index>::max())) {
const auto maxIndex =
static_cast<unsigned long long>((std::numeric_limits<Eigen::Index>::max)());
if (static_cast<unsigned long long>(rows) > maxIndex ||
static_cast<unsigned long long>(cols) > maxIndex) {
error("unwrapMatrixView: matrix dimensions exceed Eigen::Index");
}
const Eigen::Index m = static_cast<Eigen::Index>(rows);
Expand Down
1 change: 1 addition & 0 deletions tests/test_matlab_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ def test_matrix_view_arguments(self):
self.assertIn('unwrapMatrixView', header_content)
self.assertIn('mxIsSparse(array)', header_content)
self.assertIn('mwSize rows', header_content)
self.assertIn('static_cast<unsigned long long>(rows)', header_content)
self.assertIn('Eigen::Index m', header_content)
self.assertIn('Stride(m, 1)', header_content)

Expand Down
Loading