Atomicity violation during user registration

[Annoraaq]

The registering of two users can overlap such that two users with the same username or email are in the database. I suggest adding an index to the email and username fields in the database.

[braitsch]

The possibility of this happening is next to zero as once a username or email address is taken it is no longer available to any other user and the addNewAccount method which validates incoming new account requests returns in a fraction of a second.

[Annoraaq]

Indeed. But under heavy load this can change and since you don't know in which context node-login is used and adding an index takes as long as responding to this message, I still suggest to go for the index.

[braitsch]

Fair enough.