Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android bookmark widgets display incorrectly when minimized vertically #27801

Closed
Brave-Matt opened this issue Jan 13, 2023 · 9 comments · Fixed by brave/brave-core#16739
Closed
Assignees
Labels
bug feature/widgets OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes regression release/blocking release-notes/include

Comments

@Brave-Matt
Copy link

Description

If the Brave "Bookmarks" widget shows incorrectly sized icons. This is especially apparent if the widget is resized to be only a single row (displaying just the icon):
image

Steps to reproduce

  1. Add "Bookmarks" widget to Android home screen in Beta/Nightly
  2. Observe incorrectly sized icons

Issue reproduces how often

Easily/every time

Version/Channel Information:

v1.48.122
v1.49.24

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: Android 12

Additional information

Internal Convo: https://bravesoftware.slack.com/archives/C0816QH3R/p1673630441127669
User report: https://old.reddit.com/r/brave_browser/comments/105mw6r/widgets_in_beta_are_very_bad/
cc @deeppandya

@Brave-Matt Brave-Matt added OS/Android Fixes related to Android browser functionality feature/widgets labels Jan 13, 2023
@SergeyZhukovsky SergeyZhukovsky added regression priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 13, 2023
@timchilds
Copy link

@deeppandya I reproduced this on my Xiaomi Redmi Note 11 on Android 12.

The text also seems to large. In the video below the top widget is Brave, bottom widget is Chrome.

Screenrecorder-2023-01-13-11-41-12-553.mp4

@kjozwiak
Copy link
Member

As per the discussion on Slack re: the above, we'll keep pushing out 1.47.x but keep an eye on user reports via the support team. If we notice an influx of reports, we'll push the above via a HF. For now, we're going to get this into the 1.47.x maintenance release that's schedule for January 25 as per https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule#release-channel-dates.

@kjozwiak
Copy link
Member

The above requires 1.47.178 or higher for 1.47.x verification 👍

@iamgitcat
Copy link

Since today update release version updated with new widgets and now all 3 versions are same.

@krakah
Copy link

krakah commented Jan 20, 2023

Looking forward to the 1/25 update. As someone who just bookmarks a site rather than downloading an intrusive app with the same functionality, this has made my homescreen look really silly!

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.47.181 Chromium: 109.0.5414.87 (Official Build) (64-bit) 
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	Android 13; Build/TP1A.220624.014

Test Plan:

  1. Install 1.47
  2. Add bookmark widget to the home screen
  3. Resize widget vertically to 1 column
  • Verified resizing widget down to 1 column displays bookmark favicons correctly
Default Vertical Horizontal
screenshot-1674493863677 screenshot-1674493872884 screenshot-1674493906902

@iamgitcat
Copy link

Since 1.47 the size of icons is smaller, but they are not centered. It looks bad, but better than before. Beta version looks like it always was, the old good way.Screenshot_20230125-103709.jpg

@krakah
Copy link

krakah commented Jan 28, 2023

Fixed with latest update. My homescreen us normal again.

@iamgitcat
Copy link

Latest update fixed both release and beta. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/widgets OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes regression release/blocking release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants