PW-DSS-PEPPER-1003 -Enrollment #2176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 1, 2023 16:39
aweng98
reviewed
Aug 3, 2023
Contributor
aweng98
left a comment
aweng98
left a comment
There was a problem hiding this comment.
Looks Good! Need to update export-playwright-en.sh for MBC variables.
https://github.com/broadinstitute/ddp-angular/blob/develop/.circleci/export-playwright-env.sh
aweng98
reviewed
Aug 3, 2023
| import {MBCMedicalReleasePage} from '../../dss/pages/mbc/mbc-medical-release-page'; | ||
| import {MBCFollowUpSurvey1} from '../../dss/pages/mbc/mbc-follow-up-survey-1'; | ||
|
|
||
| const {MBC_USER_EMAIL, MBC_USER_PASSWORD, MBC_BASE_URL, SITE_PASSWORD} = process.env; |
Contributor
There was a problem hiding this comment.
Do you also want to create a new fixture for this study?
Contributor
Author
There was a problem hiding this comment.
In the future would be good.
Contributor
|
Hi, I don't find changes to |
aweng98
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEPPER-1003
Note: Tests don't include screenshot comparison
video.webm