FormatFieldType: renamed to VariantFieldType

[MauricioCarneiro]

fixes #171

[droazen]

I think the declaration of this enum should be moved to variant.h

[MauricioCarneiro]

if we do that, we will be exposing it to the developers. Right now it's a private gamgee implementation thing. I like it this way.

[MauricioCarneiro]

but if I follow your motivation, I think we can move this utility file into the main directory and call it VariantFieldType instead of "utils".

[droazen]

It's not a utility, and shouldn't be buried in a utilities file. With other similar enums (eg., Base, CigarOperator, etc.) we've put them in the main header. Plus there are public functions all over the place that take VariantFieldType as an argument.

[droazen]

If you rename the file from field utils to VariantFieldType I'd be ok with keeping it here.

[MauricioCarneiro]

rename but keep it in utils?

[droazen]

Actually I meant rename and move out of utils. It's not a utility

[coveralls]

Coverage increased (+0.05%) when pulling 78835ec on mc_rename_format_field_type_171 into 7b46c6a on master.

[MauricioCarneiro]

Renamed

[coveralls]

Coverage remained the same when pulling 66d5127 on mc_rename_format_field_type_171 into 7b46c6a on master.

[coveralls]

Coverage increased (+0.24%) when pulling 66d5127 on mc_rename_format_field_type_171 into 7b46c6a on master.