This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Intel test branch #315
Closed
Intel test branch #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create a new *production* mode to eliminate the -finline-functions that is no longer supported by clang 3.5 also create a global fixture for initialization of global variables in the variant reader test. closes #290
Vector end values were not passing through to the caller when accessing alleles via operator[] in the Genotype class.
Read group class Minor changes base don code review Minor improvements in code readabiity
handle bcf_*_vector_end values. This is done by passing the end value of the pointer in the constructor and modifying the increment operators. (a) Operators ++ and += advance to the end of the vector if the value at the new iterator location is equal to bcf_*_vector_end. (b) Operator == is same as the original (c) Operators -- and -= unchanged 2. Inserted test cases for variable length vectors 3. Cache current pointee value in SharedIterator and IndividualFieldValueIterator to reduce overhead 4. Use constructor with full parameter list in iterators 5. Operator[] in SharedFieldIterator, IndividualFieldIterator and IndividualFieldValueIterator works relative to m_current_data_ptr now 6. Added tests for operator[] for SharedFieldIterator, IndividualFieldIterator and IndividualFieldValueIterator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE - only for testing Travis build