List without column raises exception#11
Merged
brouberol merged 1 commit intoOct 3, 2025
Merged
Conversation
gehel
commented
Sep 11, 2025
gehel
commented
Contributor
Contributor
Author
|
This CR is stacked on top of #9 and might need to be rebased before merging. |
gehel
force-pushed
the
list_without_column_raises_exception
branch
from
daec34e to
f25283e
Compare
As described in the linked issue brouberol#10, when find_tasks is passed `columns=None` it crashes as it can't iterate `None`. `find_tasks()` now marks the `columns_phids` argument as a non optional sequence. This documents that this argument is expected to not be modified and that `None` should not be passed. Caller is modified to follow this new behaviour. fixes: brouberol#10
gehel
force-pushed
the
list_without_column_raises_exception
branch
from
f25283e to
f787ed6
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.