feat(move): Project-PHID as a CLI argument for the move command#9
Conversation
brouberol
left a comment
brouberol
left a comment
There was a problem hiding this comment.
Looks good! I have a couple of simplification suggestions.
gehel
force-pushed
the
project_phid_as_argument
branch
2 times, most recently
from
77aaa92 to
a28a05c
Compare
|
Actually, 💡 . People don't deal in PHIDs. They deal in project names. Let's maybe replace |
When working with multiple projects, it is cumbersome to edit config file or environment variables each time a different project is needed. This commit introduces a "--project-phid" argument to the "move" command, which would override "phabricator_default_project_phid". It might make sense in a next step to introduce the same "--project-phid" argument to other commands where it makes sense.
Now that we have extracted a standard way to passing `project_phid`, let's use it on the "list" command as well. See parent commit for details.
Now that we have extracted a standard way to passing `project_phid`, let's use it on the "parent" command as well. See parent commit for details.
gehel
force-pushed
the
project_phid_as_argument
branch
from
9af5788 to
3c90f00
Compare
I lazy and did not want to implement project search. But if it exists already, we should use it! PHIDs are not for humans! If we use project names instead of PHID, should we also use those in the config file? In any case, could we do this work in a subsequent PR? |
Arguments are now project and not PHIDs
Let's keep this one for a different CR. |
Humans should not be dealing with PHIDs. Let's pass project title instead and resolve them to PHID by doing a search.
gehel
force-pushed
the
project_phid_as_argument
branch
from
242881d to
6fecb68
Compare
|
Implemented the last suggestion by also extracting a |
|
Attempt to introduce that class: gehel@b941467. But it does not work, I don't quite understand how python does method handles... |
Co-authored-by: Balthazar Rouberol <br@imap.cc>
|
Thanks! |
2 participants
When working with multiple projects, it is cumbersome to edit config file or environment variables each time a different project is needed. This commit introduces a "--project-phid" argument to the "move" command, which would override
"phabricator_default_project_phid".
It might make sense in a next step to introduce the same "--project-phid" argument to other commands where it makes sense.