Fix: Correct GPG keyring path in Dockerfile.ci (fixes #99)#101
Merged
Conversation
First gpg command must use /tmp/mono-keyring.gpg not the final destination path. This ensures the keyring file is created properly before exporting to final location. Fixes #99
ReviewPath fix correct but incomplete solution Line 14: Path consistency fixed - both commands now use Missing: Suggestion: gpg --homedir /tmp --no-default-keyring \
--keyring /tmp/mono-keyring.gpg \
--export 3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF | gpg --dearmor \
> /usr/share/keyrings/mono-official-archive-keyring.gpgOr pipe directly: gpg --homedir /tmp --no-default-keyring \
--keyring /tmp/mono-keyring.gpg \
--armor --export 3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF | gpg --dearmor \
> /usr/share/keyrings/mono-official-archive-keyring.gpgTest with actual Docker build before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix GPG keyring path inconsistency in Dockerfile.ci that caused Docker build failures.
Problem
The first
gpg --recv-keyscommand was writing to/usr/share/keyrings/mono-official-archive-keyring.gpgbut the second command was trying to export from/tmp/mono-keyring.gpg, causing the export to fail.Solution
Use
/tmp/mono-keyring.gpgconsistently in both GPG commands:/tmp/mono-keyring.gpg/tmp/mono-keyring.gpgto final destinationTest plan
Fixes #99