fix(infra): chaintracks param typing + message-box-server lockfile resync - #213
Merged
sirdeggen merged 2 commits intoJun 19, 2026
Merged
Conversation
Stricter Express typings infer req.params.<name> as `string | string[]`, breaking the v2 header routes (TS2345 at lines passing params to string APIs; TS2339 on .replace). Add a firstParam() helper and normalize height/hash params (and the .bin variants) to a single string before use. Behavior unchanged; fixes the chaintracks-server Docker `npm run build`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
….json The release sync PR (#211) refreshed this lockfile with --legacy-peer-deps while it still carried the old eslint@10 stack; #212 then removed eslint from package.json. The merge left package.json (no eslint) against a lockfile still pinning eslint@10.4.1, so the Docker `npm ci --omit=dev` failed with "package.json and package-lock.json are not in sync". Regenerate the lockfile from the current (eslint-free) package.json so ts-standard's own bundled eslint resolves and npm ci passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
ty-everett
pushed a commit
to ty-everett/ts-stack
that referenced
this pull request
Jun 22, 2026
… triggering npm Release Two infra-release Docker failures + one spurious Release failure: 1. message-box-server `npm install` crashed with "Cannot read properties of undefined (reading 'extraneous')" — the lockfile committed in bsv-blockchain#213 was generated with `npm install --package-lock-only` (npm 11) and was not reconcilable by the node:20 builder. Regenerated cleanly with node:20-alpine's npm. 2. message-box-server then failed compiling better-sqlite3 (no musl prebuilt → source build) because the Dockerfile installed no toolchain. Add python3/make/g++ to the builder and (virtual, removed after) to the production stage — mirroring chaintracks-server. Full image now builds locally (linux/amd64). 3. release.yaml's `**/v*` tag trigger also matched `infra/v*`, so infra release tags ran the npm Release workflow, whose resolve-plan can't map `infra/v*` to a package and exits 1. Exclude `infra/v*` from Release's triggers (infra-release.yaml owns those tags). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes both failures in the Infra Release Docker builds (run that broke on the #211 merge to main).
1. chaintracks-server — TS build failure
infra/chaintracks-server/src/v2-routes.tsfailednpm run build:Stricter Express typings infer
req.params.<name>asstring | string[]. Added afirstParam()helper and normalized theheight/hashparams (and their.binvariants) to a single string before use. Behavior unchanged. Verified:npm ci && npm run buildexits 0.2. message-box-server — npm ci lockfile mismatch
Docker
npm ci --omit=devfailed:Merge artifact: the sync PR (#211) refreshed this lockfile with
--legacy-peer-depswhile package.json still had the eslint@10 stack; #212 then removed eslint from package.json. The merged result paired an eslint-free package.json with a lockfile still pinning eslint@10.Regenerated
infra/message-box-server/package-lock.jsonfrom the current package.json (ts-standard brings its own eslint). Verified in sync — no top-level eslint@10. (Note: the analysis suggestion torm package-lock.json && npm installfrom repo root does not apply — root is a pnpm workspace; the affected lockfile is this package's own npmpackage-lock.json.)🤖 Generated with Claude Code