Optimize large action-batch transport and Wallet Wire handoff - #360
Merged
ty-everett merged 1 commit intoJul 26, 2026
Merged
Conversation
ty-everett
requested review from
BraydenLangley,
sirdeggen and
tonesnotes
as code owners
July 26, 2026 18:55
ty-everett
force-pushed
the
codex/action-batch-large-data-streaming
branch
from
July 26, 2026 22:42
ab0677b to
98a41f2
Compare
ty-everett
force-pushed
the
codex/action-batch-large-data-streaming
branch
from
July 26, 2026 22:56
98a41f2 to
48f4e6c
Compare
|
ty-everett
commented
Jul 26, 2026
ty-everett
left a comment
Collaborator
Author
There was a problem hiding this comment.
Maintainer exact-head approval in substance (ty-everett): I reviewed commit 48f4e6cec22fd63b2141acdcc489a6d4de671a7a, rebased directly on main@78563db73edf078a7fa2f3ddd8f6b1e0a489d3e7.
Review findings were remediated before merge:
- standard storage now rejects unprepared and unrequested packed digests, preventing eager upload/storage amplification;
- authenticated HTTP pack bodies are explicitly runtime-narrowed and zero-copy normalized before binary decoding;
- exact-head CodeQL run 30224176517 passed Actions and JavaScript/TypeScript with security-extended queries, and critical alerts #213–#218 are fixed with no dismissal or suppression;
- Sonar reports an OK quality gate, zero open/confirmed issues, and zero hotspots;
- PR CI run 30224170639 passed every build, test, coverage, platform, infrastructure, policy, and final merge-gate job;
- local full suites passed: SDK 5,739 tests at 92.79% line coverage and Wallet Toolbox 1,301 tests at 71.33% line / 59.44% branch coverage;
- dependency review, Socket, audit, repository health, artifact/browser/mobile contracts, WAB, Overlay Express, synchronized edge/rate policies, and retained performance benchmarks passed;
- there are no review threads or change requests, and the working diff is one clean commit over unchanged
main.
GitHub does not permit an author to submit an APPROVED review on their own pull request, so this COMMENT review records the same exact-head maintainer decision and evidence. I approve this SHA for the authorized admin squash merge; admin authority is used only to satisfy that impossible self-approval requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Physical pack sizes are transport boundaries only. Logical transactions and scripts are chunked across packs without introducing a consensus or script-size limit.
This head is rebased onto
mainat78563db73edf078a7fa2f3ddd8f6b1e0a489d3e7.Representative measurements
Latest retained benchmark on an Apple Silicon host with Node.js v24.18.0:
Compression falls back to identity whenever it would expand a pack.
Security properties
eager: false; uploads require a prepared manifest digestuploadDigestsValidation
OK, zero open/confirmed issues, zero hotspotsThe tests and measurements use generic scripts and byte patterns only. This PR does not change package versions or publish packages.