Bug 889650: Fix crash when searching "match all of the same field" on Flags - #179
Merged
Conversation
mrenvoize
force-pushed
the
bug-889650-harmony
branch
from
August 3, 2026 16:05
57f73b8 to
86d5e29
Compare
mrenvoize
previously approved these changes
Aug 3, 2026
mrenvoize
left a comment
mrenvoize
left a comment
Contributor
There was a problem hiding this comment.
Same as 5.2 and 5.0.4 submission.. works well in my testing.
Contributor
|
Doh.. I missed the whitespace requirement changes when reviewing.. good thing we have tests :) |
Contributor
|
I opened a PR against your remote and branch @topunix, that should fix the test failures above. |
justdave
dismissed
mrenvoize’s stale review
August 4, 2026 00:07
Tests are failing, not ready to land.
justdave
previously requested changes
Aug 4, 2026
The fix for the Flags "match all of the same field" crash replaced a tab-indented line with a literal tab character instead of spaces, tripping t/005whitespace.t.
1 task
mrenvoize
self-requested a review
August 5, 2026 07:22
mrenvoize
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Harmony port of bugzilla/bugzilla#237. The grouped flag search in
_flagtypes_nonchanged was reading from $bugs_table, which has already been
reassigned to the grouped alias at that point, so the subquery referenced a
bugs_g2 table that does not exist. Reads from the real bugs table instead.
Also adds the matching regression test to CUSTOM_SEARCH_TESTS.
Additional info