Bug 889650: Fix tab character introduced in Search.pm indentation - #1
Closed
mrenvoize wants to merge 1 commit into
Closed
Bug 889650: Fix tab character introduced in Search.pm indentation#1mrenvoize wants to merge 1 commit into
mrenvoize wants to merge 1 commit into
Conversation
The fix for the Flags "match all of the same field" crash replaced a tab-indented line with a literal tab character instead of spaces, tripping t/005whitespace.t.
Owner
|
Thanks Martin, picked this up. Cherry-picked 35b26c3 onto bug-889650-harmony and pushed, so the branch on bugzilla#179 now has the detab. Closing this one since it landed via cherry-pick rather than merge (keeps the branch linear for the upstream PR). Appreciate you catching the whitespace test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FROM $bugs_table bugs_$chart_idwithFROM bugs bugs_$chart_id, which is correct (the FROM clause opens a fresh correlated subquery and must reference the realbugstable, not the outer query's aliased table variable) — but the line was re-indented with a literal tab character instead of spaces.t/005whitespace.t, which fails the sanity suite.Fix
Replace the tab with spaces, matching the alignment of the sibling
LEFT JOINlines in the same heredoc.Test plan
docker compose -f docker-compose.test-mysql.yml run --no-deps bugzilla6.test test_sanity t/*.t extensions/*/t/*.t— 30 files, 14,208 tests, all pass (previously failing ont/005whitespace.t)