Skip to content

fix(auth): persist auth outside of repo#900

Merged
mcncl merged 3 commits into
mainfrom
fix/persist_auth
Jul 7, 2026
Merged

fix(auth): persist auth outside of repo#900
mcncl merged 3 commits into
mainfrom
fix/persist_auth

Conversation

@mcncl

@mcncl mcncl commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Description

Auth currently breaks if you move outside of a project or delete/move .bk.yaml.

Changes

  • persists auth using the ~/.config/bk.yaml instead of local, so moving to a non-BK project doesn't break login

Testing

  • Tests have run locally (with go test ./...)
  • Code is formatted (with go fmt ./...)

@mcncl mcncl requested review from a team as code owners July 7, 2026 01:12

@buildsworth-bk-app buildsworth-bk-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one non-blocking regression-coverage note. I'm submitting a comment rather than approval because this changes auth/credential selection behavior.

Want to dig deeper?

The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:

Download the buildsworth logs from build 3112, then answer my questions about the findings.

Comment thread cmd/auth/login.go

@buildsworth-bk-app buildsworth-bk-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one non-blocking test-isolation note. I'm commenting rather than approving because this changes auth/credential selection behavior.

Want to dig deeper?

The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:

Download the buildsworth logs from build 3120, then answer my questions about the findings.

Comment thread cmd/auth/login_test.go
Co-authored-by: buildsworth-bk-app[bot] <265670805+buildsworth-bk-app[bot]@users.noreply.github.com>

@buildsworth-bk-app buildsworth-bk-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any new findings. I'm commenting rather than approving because this touches auth/credential selection behavior.

Want to dig deeper?

The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:

Download the buildsworth logs from build 3122, then answer my questions about the findings.

@wolfeidau wolfeidau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@mcncl mcncl merged commit 774c528 into main Jul 7, 2026
3 checks passed
@mcncl mcncl deleted the fix/persist_auth branch July 7, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants