fix(auth): persist auth outside of repo#900
Conversation
There was a problem hiding this comment.
I left one non-blocking regression-coverage note. I'm submitting a comment rather than approval because this changes auth/credential selection behavior.
Want to dig deeper?
The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:
Download the buildsworth logs from build 3112, then answer my questions about the findings.
There was a problem hiding this comment.
I left one non-blocking test-isolation note. I'm commenting rather than approving because this changes auth/credential selection behavior.
Want to dig deeper?
The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:
Download the buildsworth logs from build 3120, then answer my questions about the findings.
Co-authored-by: buildsworth-bk-app[bot] <265670805+buildsworth-bk-app[bot]@users.noreply.github.com>
There was a problem hiding this comment.
I don't have any new findings. I'm commenting rather than approving because this touches auth/credential selection behavior.
Want to dig deeper?
The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:
Download the buildsworth logs from build 3122, then answer my questions about the findings.
Description
Auth currently breaks if you move outside of a project or delete/move
.bk.yaml.Changes
authusing the~/.config/bk.yamlinstead of local, so moving to a non-BK project doesn't break loginTesting
go test ./...)go fmt ./...)