Conversation
Updates the requirements on [setuptools](https://github.com/pypa/setuptools) to permit the latest version. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v70.3.0...v83.0.0) --- updated-dependencies: - dependency-name: setuptools dependency-version: 83.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…te-70.3.0-and-lt-84.0.0 chore(deps): update setuptools requirement from <83.0.0,>=70.3.0 to >=70.3.0,<84.0.0
Bumps [https://github.com/igorshubovych/markdownlint-cli](https://github.com/igorshubovych/markdownlint-cli) from v0.49.0 to 0.49.1. - [Release notes](https://github.com/igorshubovych/markdownlint-cli/releases) - [Commits](igorshubovych/markdownlint-cli@v0.49.0...v0.49.1) --- updated-dependencies: - dependency-name: https://github.com/igorshubovych/markdownlint-cli dependency-version: 0.49.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…-/github.com/igorshubovych/markdownlint-cli-0.49.1 chore(deps): bump https://github.com/igorshubovych/markdownlint-cli from v0.49.0 to 0.49.1
There was a problem hiding this comment.
Pull request overview
This PR updates dependency constraints and CI/pre-commit automation to improve build compatibility and enforce code-quality checks in pull requests.
Changes:
- Bumped
setuptoolsupper bound from<83.0.0to<84.0.0in build requirements. - Updated pre-commit tooling (markdownlint-cli rev bump; re-enabled local
pyrighthook). - Added a dedicated GitHub Actions workflow to run
pre-commiton PRs and updatedsetup-pythonusage in existing workflows.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/beans_logging/schemas.py |
Adds an inline type-check suppression for the sink field override. |
requirements/requirements.build.txt |
Relaxes setuptools upper-bound for build tooling. |
pyproject.toml |
Relaxes setuptools upper-bound for build-system requirements. |
.pre-commit-config.yaml |
Updates markdownlint-cli and enables a local pyright hook. |
.github/workflows/publish-docs.yml |
Updates Python setup action version in the docs publish workflow. |
.github/workflows/pre-commit.yml |
Introduces a new workflow to run pre-commit on PRs. |
.github/workflows/2.build-publish.yml |
Updates Python setup action version in build/publish workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| class LogHandlerPM(LoguruHandlerPM): | ||
| type_: LogHandlerTypeEnum = Field(default=LogHandlerTypeEnum.UNKNOWN) | ||
| sink: _SinkType | None = Field(default=None) | ||
| sink: _SinkType | None = Field(default=None) # type: ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the CI/CD workflows, dependency management, and pre-commit configuration. The main highlights include updating GitHub Actions to use newer versions, adding a dedicated pre-commit workflow, and adjusting dependency version constraints for better compatibility and maintainability.
CI/CD Workflow Updates:
actions/setup-pythonto version 7 in.github/workflows/2.build-publish.ymland.github/workflows/publish-docs.ymlfor improved compatibility and security. [1] [2] [3].github/workflows/pre-commit.ymlworkflow to automatically run pre-commit checks on pull requests targetingmainanddevbranches, ensuring code quality before merging.Pre-commit and Linting Configuration:
markdownlint-cliin.pre-commit-config.yamlfromv0.49.0tov0.49.1for the latest markdown linting improvements.pyrightstatic type checker hook in.pre-commit-config.yaml, ensuring type checks are run as part of pre-commit hooks.Dependency Version Updates:
setuptoolsin bothpyproject.tomlandrequirements/requirements.build.txtfrom<83.0.0to<84.0.0to allow newer patch releases. [1] [2]Code Quality and Typing:
# type: ignorecomment to thesinkfield inLogHandlerPMto suppress type-checking errors, improving compatibility with type checkers.