Cache or Clear tables. by harikt · Pull Request #309 · cakephp/migrations

harikt · 2017-03-21T09:13:23Z

Hi,

This PR contains commit from : #308 .

~~This is WIP for there is no tests currently.~~

The idea is allow people to use cakephp/migrations as standalone .

Interested to know if you guys love this addition.

Thank you.

stickler-ci · 2017-03-21T09:13:38Z

+    {
+        $this
+            ->setName('orm-cache-build')
+            ->setDescription('Build all metadata caches for the connection. If a table name is provided, only that table will be cached.')


Line exceeds 120 characters; contains 138 characters

stickler-ci · 2017-03-21T09:13:38Z

+    {
+        $this
+            ->setName('orm-cache-clear')
+            ->setDescription('Clear all metadata caches for the connection. If a table name is provided, only that table will be removed.')


Line exceeds 120 characters; contains 139 characters

codecov-io · 2017-03-21T09:19:14Z

Codecov Report

Merging #309 into master will decrease coverage by 1.73%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
- Coverage   85.97%   84.23%   -1.74%     
==========================================
  Files          33       36       +3     
  Lines        1782     1852      +70     
==========================================
+ Hits         1532     1560      +28     
- Misses        250      292      +42

Impacted Files	Coverage Δ
src/Util/SchemaTrait.php	`0% <0%> (ø)`
src/MigrationsDispatcher.php	`100% <100%> (ø)`	⬆️
src/Command/CacheClear.php	`44.82% <44.82%> (ø)`
src/Command/CacheBuild.php	`50% <50%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0f313...4bbe93e. Read the comment docs.

dereuromark · 2017-03-21T09:23:07Z

+    /**
+     * Helper method to get the schema collection.
+     *
+     * @return false|\Cake\Database\Schema\Collection


The fallback value should be null for objects, not false.

sure. I can make the change.

ADmad · 2017-03-21T10:43:51Z

Looks like stickler is using the wrong standard for checks. The .stickler.yml from cakephp/cakephp can be copied.

lorenzo · 2017-03-21T10:51:14Z

It does make sense to me to move those shells to this plugin

…tests

harikt · 2017-03-21T15:39:49Z

Hey guys,

Can anyone help me finish writing tests for this ?

vendor/bin/phpunit tests/TestCase/Command/CacheBuildTest.php

throws

1) Migrations\Test\Command\CacheBuildTest::testExecute
Symfony\Component\Console\Exception\InvalidArgumentException: The "source" option does not exist.

UPDATE : I have already modified this. So no more source is passed ;-) .

Thank you.

lorenzo · 2017-03-23T13:50:13Z

Seems like you are passing the source CLI option somewhere in your test?

harikt · 2017-03-23T13:51:25Z

@lorenzo source ? No. See the changes. Some how the tests are failing :-/ .

lorenzo · 2017-03-23T13:58:14Z

@harikt ok, looks like it is failing because you are missing some tearDown logic

lorenzo · 2017-03-23T13:57:40Z

-
+        Cache::enable();
        $this->connection = ConnectionManager::get('test');
+        $this->connection->cacheMetadata(true);


You should revert this in tearDown

lorenzo · 2017-03-23T13:57:50Z

    {
        parent::setUp();
-
+        Cache::enable();


You need to disable in tearDown

harikt · 2017-03-23T13:59:20Z

@lorenzo other tests seems failing :( . I will investigate.

lorenzo · 2017-03-23T14:01:14Z

@harikt they fail because of corrupted state in a previous test

harikt · 2017-03-23T15:12:00Z

So there is a problem with the serialized value and the one running on containers. Do you know how we can fix that ?

Also there is a permission issues I noticed for some tests to fail on localhost. Files are in /tmp/ folder.

vendor/bin/phpunit 
PHPUnit 4.8.35 by Sebastian Bergmann and contributors.

.............................S.................................SS 65 / 99 ( 65%)
S..........................EEEEEEE

Time: 5.02 seconds, Memory: 18.00MB

There were 7 errors:

1) Migrations\Test\MigrationHelperTest::testIndexMethod
dir(/tmp/systemd-private-0645317efcd547448e31d26ec6899e87-rtkit-daemon.service-BskPka/): failed to open dir: Permission denied

/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:309
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:286
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Cache.php:451
/var/www/projects/github.com/harikt/cakephp-orm-migrations/tests/TestCase/View/Helper/MigrationHelperTest.php:46

2) Migrations\Test\MigrationHelperTest::testColumnMethod
dir(/tmp/systemd-private-0645317efcd547448e31d26ec6899e87-rtkit-daemon.service-BskPka/): failed to open dir: Permission denied

/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:309
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:286
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Cache.php:451
/var/www/projects/github.com/harikt/cakephp-orm-migrations/tests/TestCase/View/Helper/MigrationHelperTest.php:46

3) Migrations\Test\MigrationHelperTest::testColumns
dir(/tmp/systemd-private-0645317efcd547448e31d26ec6899e87-rtkit-daemon.service-BskPka/): failed to open dir: Permission denied

/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:309
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:286
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Cache.php:451
/var/www/projects/github.com/harikt/cakephp-orm-migrations/tests/TestCase/View/Helper/MigrationHelperTest.php:46

4) Migrations\Test\MigrationHelperTest::testColumn
dir(/tmp/systemd-private-0645317efcd547448e31d26ec6899e87-rtkit-daemon.service-BskPka/): failed to open dir: Permission denied

/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:309
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:286
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Cache.php:451
/var/www/projects/github.com/harikt/cakephp-orm-migrations/tests/TestCase/View/Helper/MigrationHelperTest.php:46

5) Migrations\Test\MigrationHelperTest::testValue
dir(/tmp/systemd-private-0645317efcd547448e31d26ec6899e87-rtkit-daemon.service-BskPka/): failed to open dir: Permission denied

/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:309
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:286
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Cache.php:451
/var/www/projects/github.com/harikt/cakephp-orm-migrations/tests/TestCase/View/Helper/MigrationHelperTest.php:46

6) Migrations\Test\MigrationHelperTest::testAttributes
dir(/tmp/systemd-private-0645317efcd547448e31d26ec6899e87-rtkit-daemon.service-BskPka/): failed to open dir: Permission denied

/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:309
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:286
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Cache.php:451
/var/www/projects/github.com/harikt/cakephp-orm-migrations/tests/TestCase/View/Helper/MigrationHelperTest.php:46

7) Migrations\Test\MigrationHelperTest::testStringifyList
dir(/tmp/systemd-private-0645317efcd547448e31d26ec6899e87-rtkit-daemon.service-BskPka/): failed to open dir: Permission denied

/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:309
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php:286
/var/www/projects/github.com/harikt/cakephp-orm-migrations/vendor/cakephp/cakephp/src/Cache/Cache.php:451
/var/www/projects/github.com/harikt/cakephp-orm-migrations/tests/TestCase/View/Helper/MigrationHelperTest.php:46

FAILURES!
Tests: 99, Assertions: 328, Errors: 7, Skipped: 4.

If we do a git status there are many files added. Seems we could add those to gitignore itself.

 ✘  /var/www/projects/github.com/harikt/cakephp-orm-migrations   cache  gs
On branch cache
Your branch is up-to-date with 'origin/cache'.
Untracked files:
  (use "git add <file>..." to include in what will be committed)

	cakephp_test
	composer.lock
	tests/test_app/Plugin/TestBlog/config/Migrations/
	tests/test_app/config/Create/20170323150809_TestCreate.php
	tests/test_app/config/Migrations/20170323150811_TestAutoIdDisabledSnapshotSqlite.php
	tests/test_app/config/Migrations/20170323150811_TestNotEmptySnapshotNoLockSqlite.php
	tests/test_app/config/Migrations/20170323150811_TestNotEmptySnapshotSqlite.php
	tests/test_app/config/Migrations/20170323150813_CreateUsers.php
	tests/test_app/config/TestsMigrations/schema-dump-test.lock

nothing added to commit but untracked files present (use "git add" to track)

I am leaving this to rest for now. Will come back when I have some more energy :) .

harikt · 2017-03-23T15:58:37Z

Closing this PR. Opening a rebased one.

Add cache command so it can be used standalone

4bbe93e

stickler-ci reviewed Mar 21, 2017

View reviewed changes

dereuromark reviewed Mar 21, 2017

View reviewed changes

harikt added 2 commits March 21, 2017 19:55

Merge remote-tracking branch 'upstream/master' into cache

c237e43

Return null when error occurs than returning false. Start working on …

b5e26c8

…tests

Add test for cache build

b7bb9e9

harikt changed the title ~~WIP : Cache~~ Cache or Clear tables. Mar 23, 2017

lorenzo reviewed Mar 23, 2017

View reviewed changes

Drop table if exists

1eae431

harikt added 3 commits March 23, 2017 19:34

Drop table on setup also

174ca04

Disable cache on and cache meta data on teardown

052f907

Add drop table to teardown for clear cache

232dbc6

Don't serialize, just test if cache exists

6e05586

harikt closed this Mar 23, 2017

harikt mentioned this pull request Mar 23, 2017

Cache rebased #312

Merged

HavokInspiration modified the milestone: 1.6.8 Jun 7, 2017

Conversation

harikt commented Mar 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stickler-ci Mar 21, 2017

Choose a reason for hiding this comment

Uh oh!

stickler-ci Mar 21, 2017

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Mar 21, 2017

Codecov Report

Uh oh!

dereuromark Mar 21, 2017

Choose a reason for hiding this comment

Uh oh!

harikt Mar 21, 2017

Choose a reason for hiding this comment

Uh oh!

ADmad commented Mar 21, 2017

Uh oh!

lorenzo commented Mar 21, 2017

Uh oh!

harikt commented Mar 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lorenzo commented Mar 23, 2017

Uh oh!

harikt commented Mar 23, 2017

Uh oh!

lorenzo commented Mar 23, 2017

Uh oh!

lorenzo Mar 23, 2017

Choose a reason for hiding this comment

Uh oh!

lorenzo Mar 23, 2017

Choose a reason for hiding this comment

Uh oh!

harikt commented Mar 23, 2017

Uh oh!

lorenzo commented Mar 23, 2017

Uh oh!

harikt commented Mar 23, 2017

Uh oh!

harikt commented Mar 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

harikt commented Mar 21, 2017 •

edited

Loading

harikt commented Mar 21, 2017 •

edited

Loading