You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove retired screenshot-diff analysis while retaining the released pixel and structured region contracts.
The optional ocr and nonTextDeltas fields remain in the TypeScript result contract as deprecated compatibility fields, but the analyzers no longer run and the fields are not emitted. Human output remains compact; no schema migration is required.
Live iOS simulator evidence against Agent Device Tester: captured a baseline, toggled Lab online, then ran pnpm ad diff screenshot with JSON output. It returned the primary toggle region at x=306 y=327 60x24, 1,310 changed pixels in that region, and 2,019 changed pixels total (0.57%). The retired optional analysis fields were absent.
Exact head dcf11e8 is not ready because the simplified structured output silently removes shipped API fields. diff screenshot --json and the public runtime result directly expose ScreenshotDiffResult; this patch removes ocr, nonTextDeltas, and region fields including densityPercentage, shape, size, location, colors/luminance, and dominantChange. These fields landed in commit 4b7ee246, which is contained in released tags v0.18.1 through v0.20.3, so they require preservation or an explicit compatibility/versioned migration. Updating tests to stop asserting them does not migrate consumers. The reduced human text is coherent and CI is green, but structured JSON/Node compatibility must be addressed. Also add reproducible live diff screenshot device evidence (command plus artifact); the PR\x27s manual-validation sentence is not independently reviewable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove retired screenshot-diff analysis while retaining the released pixel and structured region contracts.
The optional
ocrandnonTextDeltasfields remain in the TypeScript result contract as deprecated compatibility fields, but the analyzers no longer run and the fields are not emitted. Human output remains compact; no schema migration is required.Validation
VITEST_MAX_WORKERS=1 pnpm check:affected --base origin/main --runLab online, then ranpnpm ad diff screenshotwith JSON output. It returned the primary toggle region atx=306 y=327 60x24, 1,310 changed pixels in that region, and 2,019 changed pixels total (0.57%). The retired optional analysis fields were absent.