Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased

- `diff screenshot` no longer runs the retired best-effort OCR and non-text analyzers. Their optional `ocr` and `nonTextDeltas` fields remain in the result type for source compatibility but are no longer emitted; use the baseline/current images and diff artifact with vision for qualitative interpretation.
- Breaking: removed the deprecated `--session-locked` and `--session-lock-conflicts` flags. Use `--session-lock reject|strip` instead; passing either old flag now fails with `Unknown flag: ... Use --session-lock reject|strip instead.`
- Breaking: removed the `replay export --format` flag. `replay export` always writes Maestro YAML.
- Breaking: removed the unused `LeaseAllocatePayload`, `LeaseHeartbeatPayload`, and `LeaseReleasePayload` type exports from `agent-device/contracts`. Lease request metadata is fully described by `DaemonRequestMeta`.
Expand Down
8 changes: 4 additions & 4 deletions src/__tests__/cli-diff.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,9 @@ describe('cli diff commands', () => {
const payload = JSON.parse(result.stdout);
assert.equal(payload.success, true);
assert.equal(payload.data.match, true);
assert.equal(Object.hasOwn(payload.data, 'schemaVersion'), false);
assert.equal(Object.hasOwn(payload.data, 'ocr'), false);
assert.equal(Object.hasOwn(payload.data, 'nonTextDeltas'), false);
assert.equal(payload.data.differentPixels, 0);
assert.equal(payload.data.totalPixels, 100);
assert.equal(payload.data.mismatchPercentage, 0);
Expand Down Expand Up @@ -382,10 +385,7 @@ describe('cli diff commands', () => {
assert.match(result.stdout, /Diff image:/);
assert.match(result.stdout, /Current overlay:/);
assert.match(result.stdout, /diff\.current-overlay\.png \(1 refs\)/);
assert.match(
result.stdout,
/size=large shape=large-area density=100% avgColor=#000000->#ffffff luminance=0->255/,
);
assert.match(result.stdout, /1\. x=0 y=0 10x10, 100% of diff/);
assert.match(result.stdout, /overlaps @e1 "Continue", 12% of region/);
} finally {
fs.rmSync(dir, { recursive: true, force: true });
Expand Down
137 changes: 0 additions & 137 deletions src/screenshot-diff/__tests__/screenshot-diff-non-text.test.ts

This file was deleted.

131 changes: 0 additions & 131 deletions src/screenshot-diff/__tests__/screenshot-diff-ocr.test.ts

This file was deleted.

6 changes: 4 additions & 2 deletions src/screenshot-diff/__tests__/screenshot-diff.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ test('identical images produce match: true with 0% mismatch', async () => {
assert.equal(result.differentPixels, 0);
assert.equal(result.mismatchPercentage, 0);
assert.equal(result.totalPixels, 100);
assert.equal(result.ocr, undefined);
assert.equal(result.nonTextDeltas, undefined);
assert.equal(Object.hasOwn(result, 'ocr'), false);
assert.equal(Object.hasOwn(result, 'nonTextDeltas'), false);
assert.equal(result.dimensionMismatch, undefined);
assert.equal(result.diffPath, undefined, 'diffPath should not be set when images match');
// No diff image should be written when images match
Expand Down Expand Up @@ -310,8 +314,6 @@ test('dimension mismatch returns expected vs actual sizes', async () => {
assert.equal(result.mismatchPercentage, 100);
assert.equal(result.diffPath, undefined, 'diffPath should not be set for dimension mismatch');
assert.equal(result.regions, undefined);
assert.equal(result.ocr, undefined);
assert.equal(result.nonTextDeltas, undefined);
assert.deepEqual(result.dimensionMismatch, {
expected: { width: 10, height: 20 },
actual: { width: 15, height: 25 },
Expand Down
Loading
Loading