refactor: restore pngjs codec - #1498
Merged
Merged
Conversation
|
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
Code review is clean at One validation gap remains before merge: exact-head smoke/package jobs do not execute the bundled codec through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
pngjsas the bundled PNG codec and remove the bespoke codec introduced in #609.The existing worker, resize, screenshot-diff, and canonical error contracts remain intact.
pngjsis bundled into the published output, adds no transitive dependencies, and replaces the custom codec implementation and its codec-specific test suite. The change touches 12 files and stays within the PNG utility and bundling scope.Validation
PNG worker, resize, and screenshot-diff tests pass. The related Vitest suite passes with
VITEST_MAX_WORKERS=1, and tooling checks covering formatting, lint, typecheck, layering, fallow, metadata, declarations, and production bundling pass.The full affected gate later hit an unrelated 5-second timeout in
ensureXctestrunArtifact aborts only the disconnected request build and preserves concurrent unrelated builds; CI remains authoritative for that lane.