Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the plugin to Castle Android SDK 4.0.2 and Castle iOS SDK 4.2.0.
Replaces #63. The version goes straight from 2.2.1 to 4.0.0 so that the plugin major matches the major version of the native SDKs it wraps — there is no 3.x release.
Breaking changes
Castle 3.2.0), socastle_flutter.podspecis removed. Note thatflutter pub getfails for every platform while SPM is disabled, so consumers on Flutter < 3.44 must runflutter config --enable-swift-package-manager.flushIfNeeded(url),userAgentandqueueSize— these no longer exist in the native SDKs. The removal list was derived from the shipped binaries (CastleSDK.swiftinterfaceandjavapover the 4.0.2 AAR), not from the docs.Fixes and enhancements
advertisingIdentifier(id)now works on Android via the newadIdProvideroption; it was previously a no-op there.baseURLAllowListnever being applied on iOS — Dart sends strings but the plugin cast them toArray<URL>, so the cast always failed silently.FlutterFrameworkpackage that the Flutter tool never generates. Flutter is provided by the Xcode project, so plugins must not declare it.cirrusci/flutterimage (stuck on Dart 2.19.4, which cannot satisfy the new SDK floor) toghcr.io/cirruslabs/flutter:stable, and SPM is enabled beforeflutter pub get.Verification
flutter analyzeclean,flutter testpassingCastleSDK.frameworkembedded, resolved 4.2.0) and an Android API 35 emulator (libcas.soloaded). Both produce a real request token andX-Castle-Request-Token.testjob was run inside the new CI image.