(v2.x) Remove space in user-defined literal operators to fix MSVC C4996 warning - #3184
Merged
Merged
Conversation
Remove the space between "" and the suffix in user-defined literal operators (e.g. operator ""_a instead of operator "" _a) to avoid MSVC deprecation warning C5311.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2.x #3184 +/- ##
=======================================
Coverage 90.08% 90.08%
=======================================
Files 113 113
Lines 5040 5040
=======================================
Hits 4540 4540
Misses 500 500 🚀 New features to boost your workflow:
|
Member
|
Sure, why not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the space between "" and the suffix in user-defined literal operators (e.g. operator ""_a instead of operator "" _a) to avoid MSVC deprecation warning C5311.
Description
In MSVC,
operator "" _a(with a space between""and the suffix) triggers deprecation warning C5311.The standard-compliant form is
operator ""_a(no space), as described on cppreference.