chore(mypy): enable stricter type checking flags - #731
Merged
Conversation
Enables 8 flags that pass with zero errors: - warn_unused_configs / warn_redundant_casts / warn_unused_ignores - strict_equality / extra_checks / no_implicit_reexport - check_untyped_defs / disallow_untyped_decorators Also removes a stale `# type: ignore[override]` in certs.py that was flagged by warn_unused_ignores. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables 8 mypy flags that pass with zero code changes (plus one stale
# type: ignoreremoval):warn_unused_configswarn_redundant_castscast()callswarn_unused_ignores# type: ignorecommentsstrict_equality==comparisonsextra_checksno_implicit_reexportcheck_untyped_defsdisallow_untyped_decoratorsSkipped
--disallow-incomplete-defsand--disallow-untyped-defs(297 errors) — those are a future PR with annotation work.Test plan
uv run mypy censys— no issues in 47 source files🤖 Generated with Claude Code