fix: compare DataViews by their effective byte range - #114
Merged
Conversation
43081j
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deep-eqlcompares twoDataViews by their full backingArrayBuffers, ignoringbyteOffset/byteLength. So two views over the same buffer at different offsets with different bytes compare equal (a false positive — the assertion passes when the payloads differ), and two views over different buffers with identical effective bytes compare unequal. Node'sutil.isDeepStrictEqualscopes the comparison to the view window; this does the same.This is the fix suggested by @keithamus in #53 ("slice the ArrayBuffers by the respective byteOffset and byteLength").
Fixes #53.