Skip to content

Conversation

@jackkoenig
Copy link
Contributor

Previously it would randomly pick widths [1, 4] and run several duplicate tests, now it tests everything in the inclusive range 1 to 7 exactly once which also takes less time.

smallPosInts and its use with ScalaCheck is a bit silly, we should just do more loops over parameters.

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Previously it would randomly pick widths [1, 4] and run several
duplicate tests, now it tests everything in the inclusive range 1 to 7
exactly once which also takes less time.
@jackkoenig jackkoenig added the Internal Internal change, does not affect users, will be included in release notes label Aug 11, 2025
@jackkoenig jackkoenig merged commit 7bf6a17 into main Aug 13, 2025
18 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/tweak-popcount-test branch August 13, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internal Internal change, does not affect users, will be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants