Skip to content

Conversation

@adkian-sifive
Copy link
Contributor

This is natively supported in Scala 2 but in Scala 3 we have to explicitly add support for any classes we want to select into. The Scala 2 Selectable trait is a stub.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Make Modules Selectable in Scala 3

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@adkian-sifive adkian-sifive added the Scala 3 Changes related to upgrading to Scala 3 label Nov 25, 2025
@adkian-sifive adkian-sifive force-pushed the adkian-sifive/scala3-moduleintf-updates branch from dd6fc56 to e659f70 Compare November 25, 2025 21:26
@adkian-sifive adkian-sifive force-pushed the adkian-sifive/scala3-moduleintf-updates branch from 4572526 to 719a699 Compare November 25, 2025 21:50
@jackkoenig jackkoenig enabled auto-merge (squash) November 25, 2025 21:52
@jackkoenig jackkoenig merged commit c3a1aef into main Nov 25, 2025
16 checks passed
@jackkoenig jackkoenig deleted the adkian-sifive/scala3-moduleintf-updates branch November 25, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scala 3 Changes related to upgrading to Scala 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants