Skip to content

[bugfix] Rename Module def layers to moduleLayers#5261

Merged
adkian-sifive merged 3 commits intomainfrom
adkian-sifive/module-layers-rename
Apr 9, 2026
Merged

[bugfix] Rename Module def layers to moduleLayers#5261
adkian-sifive merged 3 commits intomainfrom
adkian-sifive/module-layers-rename

Conversation

@adkian-sifive
Copy link
Copy Markdown
Contributor

@adkian-sifive adkian-sifive commented Apr 8, 2026

The name collision between the package name and this def causes issues with name resolution in Scala 3 and unnecessarily makes layers a Chisel keyword

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@adkian-sifive adkian-sifive requested a review from jackkoenig April 8, 2026 22:33
@adkian-sifive adkian-sifive added the Bugfix Fixes a bug, will be included in release notes label Apr 8, 2026
Copy link
Copy Markdown
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change but let's go one step further

Comment thread core/src/main/scala/chisel3/Module.scala Outdated
@adkian-sifive adkian-sifive enabled auto-merge (squash) April 9, 2026 20:34
@adkian-sifive adkian-sifive merged commit c2d6a09 into main Apr 9, 2026
28 checks passed
@adkian-sifive adkian-sifive deleted the adkian-sifive/module-layers-rename branch April 9, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Fixes a bug, will be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants