Ensure past intrinsics are emitted with an explicit clock#5291
Merged
jackkoenig merged 2 commits intochipsalliance:mainfrom May 7, 2026
Merged
Ensure past intrinsics are emitted with an explicit clock#5291jackkoenig merged 2 commits intochipsalliance:mainfrom
jackkoenig merged 2 commits intochipsalliance:mainfrom
Conversation
AI-assisted-by: Claude Code: claude-sonnet-4.6
9d40e2c to
6528822
Compare
jackkoenig
approved these changes
May 7, 2026
Contributor
jackkoenig
left a comment
There was a problem hiding this comment.
LGTM, are there any other operations that need similar treatment?
fabianschuiki
approved these changes
May 7, 2026
Contributor
fabianschuiki
left a comment
There was a problem hiding this comment.
Very neat! Thanks for cleaning this up @TaoBi22 🥳. It would be amazing if we could do the same thing for ltl.delay as we've chatted about in the past -- then we could get rid of that ugly ltl.clock altogether 😏
Co-authored-by: Jack Koenig <jack.koenig3@gmail.com>
Contributor
Author
As @fabianschuiki alluded to, there's a plan to make the same changes to ltl.delay but I believe those are stalled right now so we don't have an explicit clocking operand for that op yet. Once we have one I'd imagine we'll want to make the same changes here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slight modification to the intrinsic introduced by #5260 to ensure explicit clocks are always emitted - this is so we can avoid relying on implicit clock inference from IR in CIRCT (relevant CIRCT PR).
First time Chisel contributor so please let me know if I've missed anything!
AI-assisted-by: Claude Code: claude-sonnet-4.6
CC: @fabianschuiki
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Emitted
pastintrinsics are now always emitted with explicit clocks.Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.