feat(cli): add chunksetbin and chunksetbinstate - #1
Merged
Conversation
Binary chunk writes over the CHUNKSETBIN command (chunkdb server 1.3+). The payload is given as hex or read from a file with --in, in the byte layouts chunkbin / chunkbinstate print, so chunkbin --out output can be written back unchanged. Both commands work in shell as well. chunkclient gains CommandWithPayload, which writes the request line, the raw bytes, and the empty-line terminator before reading the response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLI side of chunkdb/chunkdb#17 (
CHUNKSETBIN, server 1.3+).chunksetbin <cx> <cy> <hex>/chunksetbinstate <cx> <cy> <hex>, or--in <file>to send raw bytes from a file. The layouts are whatchunkbin/chunkbinstateprint, sochunkbin --out xfollowed bychunksetbin --in xcopies a chunk. Also available inshell.chunkclient.CommandWithPayloadwrites the request line, the bytes, and the empty-line terminator, then reads the response as before.shell(parseChunkSetBinArgs); the unit table covers hex, bad hex, bad ints, missing payload, and--incombined with hex. README and CHANGELOG updated.Test plan
gofmt,go vet,go test ./...mainat 872ac88 (4×4×4-bit geometry): hex write +chunkbinread-back,chunkbinstate --outthenchunksetbinstate --in, server-side length error surfaced,shellpath