fix(protect): handle undefined and null values in model interfaces - #144
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends model interface handling to cover undefined in addition to null, updating both single and bulk operations, and adds corresponding tests.
- Expand
nullFieldstype and logic to treatundefinedas a first‐class case - Mirror changes in
prepareBulkModelsForOperation - Add unit tests for encryption/decryption with
undefined - Publish a changeset entry for the fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/protect/src/ffi/model-helpers.ts | Allow nullFields to store undefined and adjust checks |
| packages/protect/tests/protect.test.ts | New tests for single and bulk operations handling undefined |
| .changeset/thirty-otters-cough.md | Document the fix for null/undefined handling (with typo) |
Comments suppressed due to low confidence (1)
packages/protect/src/ffi/model-helpers.ts:131
- [nitpick] The variable name
nullFieldsnow holds bothnullandundefinedvalues, which may be misleading; consider renaming it to something likenullishFieldsto clarify its purpose.
nullFields: Record<string, null | undefined>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CDThomas
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the model interfaces don't handle
undefinedcorrectly. Now the model interfaces will handle bothnullandundefinedvalues correctly