docs(handoff): close the app-analytics stream and correct a dedup claim that was measured wrong - #204
Merged
Merged
Conversation
…im that was measured wrong The canonical handoff doc on `main` had gone stale in the way that costs the next session real time: it still listed shipped work as pending, and carried one confident claim that measurement disproved. 🔴 THE DEDUP ADVICE WAS WRONG AND WOULD HAVE SHIPPED A BROKEN METRIC. The doc said \"per-mount, so unique views need query-side dedup\". `blockInstanceId` is NOT per-mount — it is `page_apb_<ULID>`, roughly one per PLACEMENT. Measured on prod: 124 rows carried 28 distinct `blockInstanceId` across 27 distinct `appBlockId`, ~1:1 with the app, so deduping on it reports ~1 unique viewer per app. Corrected in place, with the measurement, because the wrong version was specific and plausible enough to be followed. Brought current: - Follow-ups #6 and #5 marked DONE (civitai#3613 + cli#195, civitai#3626), plus cli#193/#194 and civitai#3627. The DONE table goes 8 -> 15 PRs. - `preview / component-tests` is no longer an open question: it reported success on #3606 and every subsequent PR (1259/1259), verified by reading the locator at each PR's head SHA rather than inferring from timing. - Deploy/verify status now records that the feature was verified IN PRODUCTION, not merely deployed — with the caveat that 20ms against ~125 rows in one partition proves the query is correct today, not that partition pruning holds at scale. - Records how to actually READ the preview component log (it lives in the Tekton taskrun, not behind the GitHub status URL), and that the taskrun reports Succeeded even when the suite fails because the step is report-only. - The pins rot recurred within a day exactly as predicted — cli#203 re-bumped both pins on 2026-08-05 — so that is now documented as a standing property of the repo, not an incident to diagnose a third time. - Adds the marketplace search-debounce flake (338ms measured against its own 300ms budget) as a latent issue for whoever owns that test. A security finding from this stream was reported privately per SECURITY.md. The mechanism is deliberately NOT in this doc — only the operational consequence, and a pointer to ask security before changing the ingest path. Docs-only; `make ci` green and `gofmt -s -l .` prints nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vvMdxcMKJP9ripQLEiPm9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only. The canonical handoff doc on
mainhad gone stale in the way that costs the next session real time — it listed shipped work as pending, and carried one confident claim that measurement disproved.The correction that matters
The doc said follow-up #6 was "per-mount, so unique views need query-side dedup."
blockInstanceIdis not per-mount. It ispage_apb_<ULID>, roughly one per placement. Measured on prod: 124 rows carried 28 distinctblockInstanceIdacross 27 distinctappBlockId— ~1:1 with the app. Deduping on it would have reported ~1 unique viewer per app.The correct identity is
userId, and anonymous rows all carryuserId = 0, so they needipinstead — henceuniqExactIf(userId, isAnon=0) + uniqExactIf(ip, isAnon=1)as shipped in civitai#3613. Querying prod before building is what caught it.I corrected this in place rather than just striking it, because the wrong version was specific and plausible enough to be followed.
Brought current
preview / component-testsis no longer an open question. It reported success on #3606 and every subsequent PR in the stream (1259/1259). Verified by reading the locator at each open PR's head SHA — PRs with the baregetByText('Generations')failed, PRs with{ exact: true }passed — rather than inferring from timing.civitai app metrics gen-matrixprinted real non-zero App loads, cross-checked against a hand-written ClickHouse query and against the reader's own entry insystem.query_log. Kept the caveat: 20ms against ~125 rows in a single partition proves the query is correct today, not that partition pruning holds at scale.Succeededeven when the suite fails because the step is report-only. That cost time twice; now it's written down.await fill()calls against a 300ms debounce and measured 338ms locally. It failed once on civitai#3627's preview run and passed on a sibling PR ten minutes earlier.Security
A finding from this stream was reported privately to security@civitai.com per
SECURITY.md, which forbids public issues and PRs that demonstrate the issue. The mechanism is deliberately not in this doc — only the operational consequence (treat App loads / unique viewers as untrusted input; don't build payouts, ranking, discovery or leaderboards on them) and a pointer to ask security before changing the ingest path. Verified: the diff contains none of the mechanism.make cigreen;gofmt -s -l .prints nothing.🤖 Generated with Claude Code
https://claude.ai/code/session_017vvMdxcMKJP9ripQLEiPm9