feat: add --logs-collector-enabled flag to kubernetes create Fixes #485#596
Open
yuvarajrece wants to merge 4 commits into
Open
feat: add --logs-collector-enabled flag to kubernetes create Fixes #485#596yuvarajrece wants to merge 4 commits into
yuvarajrece wants to merge 4 commits into
Conversation
Added a flag to enable or disable logs collection for the Civo platform dashboard.
Added logs collector feature to Kubernetes creation command.
Contributor
Author
|
@alessandroargentieri @alejandrojnm Kindly review the pr and approve it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #485
Adds a
--logs-collector-enabledflag tocivo kubernetes create,allowing users to control whether the logs collector is installed on a
new cluster.
regardless of node size.
standard small/xsmall nodes (
g4s.kube.small,g4s.kube.xsmall) tosave node resources, and an informational message is printed:
"Logs collector not installed by default to save resource on small and
xsmall standard nodes. If you wish to enable logs collector create the
cluster with LogsCollectorEnable set to true"
API's own default applies.
Depends on civo/civogo#<PR_NUMBER_HERE> for the underlying
LogsCollectorEnabledfield onKubernetesClusterConfig— needs to bemerged and released before this PR can build against a real civogo
version bump (currently uses a local
replaceonly for testing, removedbefore submission).
Testing
Added unit tests in
utility/kubernetes_test.gocovering node-sizedetection and the enable/disable resolution logic (explicit flag,
auto-disable on standard small/xsmall, default-deferred on other sizes,
and confirming non-standard tiers like performance/RAM/CPU-optimized are
not affected).