Announce each ClickCrystals staff member only once per server - #153
Closed
I-No-oNe wants to merge 3 commits into
Closed
Announce each ClickCrystals staff member only once per server#153I-No-oNe wants to merge 3 commits into
I-No-oNe wants to merge 3 commits into
Conversation
MixinGui mix into Gui, but cancelled branch cast this to AccessorMinecraftClient, which mix into Minecraft. Every cancelled screen change throw ClassCastException, so joining server with no-load-screen on kill the connection on level loading screen. Go through mc.gui.setScreen(null). Invoker for setScreenAndShow now unused, so drop it.
Server push resource pack during configuration phase. No player then, so MixinConnection dropped the event and the module saw nothing. Packet event now fire regardless and carry the listener that got the packet, which exist in both phases and own the connection the spoofed handshake go back on.
I-No-oNe
force-pushed
the
fix/staff-join-notification-spam
branch
from
August 6, 2026 18:06
10dc414 to
a4091f4
Compare
6 tasks
Contributor
Author
|
Superseded by #154, which carries all four fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The "CC Staff Joined!" notification fired on every
ClientboundPlayerInfoUpdatePacketthat carriedADD_PLAYERfor a staff member. Servers re-send those entries on tab list refreshes and on every lobby switch, and notifications are only deduplicated by object identity, so the same staff member was announced over and over.NetworkEventListenernow remembers which player ids it has already walked and skips the ones it has seen, so each staff member is announced once. The set is cleared on game leave, so rejoining a server announces them again.Related issues
None open for this.
Checklist: