Fix join crash, blocked resource packs, staff join spam and command prefix - #154
Open
I-No-oNe wants to merge 4 commits into
Open
Fix join crash, blocked resource packs, staff join spam and command prefix#154I-No-oNe wants to merge 4 commits into
I-No-oNe wants to merge 4 commits into
Conversation
MixinGui mix into Gui, but cancelled branch cast this to AccessorMinecraftClient, which mix into Minecraft. Every cancelled screen change throw ClassCastException, so joining server with no-load-screen on kill the connection on level loading screen. Go through mc.gui.setScreen(null). Invoker for setScreenAndShow now unused, so drop it.
Server push resource pack during configuration phase. No player then, so MixinConnection dropped the event and the module saw nothing. Packet event now fire regardless and carry the listener that got the packet, which exist in both phases and own the connection the spoofed handshake go back on.
glfwGetKeyName renames printable keys after the active operating system layout, so the default comma prefix reported itself as whichever letter the layout puts on that key. Chat compares the prefix against typed characters, so any command a user wrote with the documented prefix missed the check and was sent to the server as a public message. Printable GLFW key codes are the characters themselves, so resolve those directly and only fall back to glfwGetKeyName for the remaining keys.
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Four client fixes, one commit each. Replaces #150, #151, #152 and #153.
no-load-screen-MixinGuicastthistoAccessorMinecraftClient, which mixes intoMinecraft, so every cancelled screen change threw aClassCastExceptioninside packet handling and dropped the connection. Now usesmc.gui.setScreen(null). That invoker was its only user, so it is gone.no-server-packsblocked nothing - packs are pushed during the configuration phase, butMixinConnectiondroppedPacketReceiveEventwhile there was no player. The event is now passed anyway and carries thePacketListener, which the module answers the handshake on.GameJoinEventandEntityDamageEventkeep their player check.ADD_PLAYERon tab list refreshes and lobby switches.NetworkEventListenernow announces each id once and forgets them on game leave.getKeyNameran the prefix throughglfwGetKeyName, which renames printable keys after the system keyboard layout. Printable key codes are already their character, so those are returned directly.Related issues
None open for these.
Checklist: