Rename the #_ toggle commands to "discard"#705
Merged
Conversation
Clojure and edn officially call `#_` the discard reader macro, and clojure-mode already uses that term for `clojure-discard-face`. Rename the toggle commands to match: `clojure-toggle-discard', `clojure-toggle-discard-surrounding-form' and `clojure-toggle-discard-defun', keeping the old `clojure-toggle-ignore*' names as obsolete aliases. Keybindings, menu, docstrings and the README are updated accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clojure and edn officially call
#_the discard reader macro, and clojure-mode already uses that term on the font-lock side (clojure-discard-face, #688). The toggle commands were the odd ones out, still calling it "ignore".Renames them to match:
clojure-toggle-ignore->clojure-toggle-discardclojure-toggle-ignore-surrounding-form->clojure-toggle-discard-surrounding-formclojure-toggle-ignore-defun->clojure-toggle-discard-defunThe old names stay as
define-obsolete-function-aliases, so existing configs and keybindings keep working (with a deprecation warning). Keybindings, menu labels, docstrings and the README are updated too; there is a test covering the aliases.Part of an effort to standardize on "discard" across the clojure-emacs Emacs packages (CIDER just did the same for its
cider-comment-styleoption).