[flink] Fix RecursionError in create_session method#4085
Merged
Harshg999 merged 3 commits intocloudera:masterfrom Apr 2, 2025
Merged
[flink] Fix RecursionError in create_session method#4085Harshg999 merged 3 commits intocloudera:masterfrom
Harshg999 merged 3 commits intocloudera:masterfrom
Conversation
|
✅ Test files were modified. Ensure that the tests cover all relevant changes |
Backend Code Coverage Report •
Pytest Report
|
Harshg999
approved these changes
Mar 27, 2025
Collaborator
Harshg999
left a comment
Harshg999
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
agl29
reviewed
Mar 28, 2025
grzegorz8
force-pushed
the
flink-editor-fix-create-session
branch
from
28d4e48 to
7884fb2
Compare
Collaborator
|
@grzegorz8 Could you please add a unittest as well? 😊 |
Contributor
Author
Basic tests added. |
grzegorz8
force-pushed
the
flink-editor-fix-create-session
branch
from
8af7adf to
3a63894
Compare
agl29
approved these changes
Apr 2, 2025
Collaborator
agl29
left a comment
agl29
left a comment
There was a problem hiding this comment.
Nice one, LGTM!
@grzegorz8 Thanks for the contribution—it’s really appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change fixes RecursionError when creating session in Flink SQL editor (reported here).
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.