dont reinstall same binary versions - #1003
Conversation
|
@steveklabnik if you have time could you take a look? really appreciate the straightforward API you've provided with the |
9a848a3 to
1ca2784
Compare
EverlastingBugstopper
changed the title
EverlastingBugstopper
added
status - needs review
and removed
status - work in progress
labels
70cf17e to
bd198cc
Compare
bd198cc to
f578b30
Compare
|
this is good to go once a new version of binary-install is released. going to open another issue for some more work i'd like to do but it depends on work in #1190 so it should be ok to go through with this as is |
|
binary-install has been published so this is ready for review. really excited for this to land.. finally |
|
Awesome! Thanks @EverlastingBugstopper I will try the binary once it's released. |
| vendored-openssl = ['openssl/vendored'] | ||
|
|
||
| [profile.release] | ||
| debug = true |
There was a problem hiding this comment.
oh i was using this to debug, great great catch.
background: wranglerjs doesn't download a binary if you're in debug mode so i was building in release mode but still wanted some sorta debug annotation i think? honestly i added this so long ago i kinda forget why i added it
There was a problem hiding this comment.
okay i thought it smelled funny 😀
5 participants
Fixes #768
This relies on this PR in @rustwasm/binary-install