fix(home): restore favorite/recent display-name auto-refresh (signal-native) - #5426
Merged
norman-abramovitz merged 5 commits intoJun 6, 2026
Conversation
norman-abramovitz
approved these changes
Jun 6, 2026
norman-abramovitz
left a comment
Contributor
There was a problem hiding this comment.
basic testing and LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the favorite/recent display-name auto-refresh that was lost when the ngrx
requestDataengine was removed — renaming an app/org/space/endpoint in CF now updates its favorite and recent cards again, signal-natively.FreshEntityNameService(core) resolves a favorite/recent's freshly-fetched name from the per-endpoint signal stores:EndpointDataService.apps()/orgs()/spaces()viaEndpointDataRegistry.peek()(CF entities) andEndpointsSignalService.endpoints()(endpoints). Returns null when no fresh data is loaded.favorites-meta-cardrendersfreshName ?? storedNameand persists a corrected name viaUserFavoritesDataService.updateMetadataon a delta.recent-entitieswrites corrected names back throughRecentlyVisitedDataService.set; the display updates via the existing state pipeline.peek(), so names refresh wherever the endpoint's data has been loaded (e.g. the home page); elsewhere the last-known name is shown.Scope is the full favoritable/recent set — applications, organizations, spaces, and endpoints.
Test Plan
FreshEntityNameService(7),favorites-meta-card(6),recent-entities(3); fullcoreproject 648 pass.make check gategreen (lint + production build + all frontend/backend suites).