Skip to content

App detail: merge Instances into Summary, scaling UX, live instance telemetry - #5427

Merged
norman-abramovitz merged 22 commits into
cloudfoundry:developfrom
nabramovitz:fix/app-detail-merge-live-instances
Jun 7, 2026
Merged

App detail: merge Instances into Summary, scaling UX, live instance telemetry#5427
norman-abramovitz merged 22 commits into
cloudfoundry:developfrom
nabramovitz:fix/app-detail-merge-live-instances

Conversation

@nabramovitz

Copy link
Copy Markdown
Contributor

Summary

Consolidates the CF app-detail Instances experience into the Summary tab and restores/clarifies instance scaling + telemetry — signal-native throughout. The Prometheus Metrics tab is untouched.

  • Merge & route: fold the Instances tab content into Summary; drop the standalone tab; legacy …/instances redirects to summary (deep-links repointed).
  • Scaling UX: Summary scale card gets explicit Running/Desired labels, in-place controls, scale-down floored at 0 (no negative requests), scale-to-zero confirmation preserved, label/input associated.
  • Usage gauge: restore the per-instance percentage (148 / 256 MB (58%)).
  • Instances accordion: gates live polling — expand = live (5s, adjustable 5s/10s/30s); collapse = frozen last values + timestamp; proportion-bar header (amber when running < desired).
  • Live trend charts: CPU/Mem/Disk sampled from the existing app-stats poll into a capped in-memory ring buffer (no Prometheus needed); humanized byte axes.
  • Legend behavior: per-metric instance hide that persists across the live refresh (enforced via a chart plugin, since Chart.js drops dataset.hidden on update), plus a momentary All metrics overlay that applies a selection across all three charts (AND-merge to reconcile differences) and auto-restores per-metric state on deactivate.

Test plan

  • Frontend unit/component tests (vitest) green locally; full make check gate green prior to the legend follow-ups.
  • CI gate (lint + frontend vitest + backend go).
  • Manual: Summary shows collapsed Instances accordion (proportion bar + timestamp); expand → live table + 3 charts build; scale 0↔1; change sample interval; per-metric legend hide survives a poll; All-metrics overlay applies/reverts; …/instances redirects to Summary; Metrics tab still works where a metrics endpoint is connected.

@norman-abramovitz norman-abramovitz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norman-abramovitz
norman-abramovitz merged commit 6292a50 into cloudfoundry:develop Jun 7, 2026
12 checks passed
@nabramovitz
nabramovitz deleted the fix/app-detail-merge-live-instances branch June 7, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants