Adopt fw-capi quota contract fixes - #5442
Merged
norman-abramovitz merged 2 commits intoJun 12, 2026
Merged
Conversation
fw-capi corrected three CF v3 contract discrepancies found by a docs-contract audit and verified live: quota delete methods now return the async job ref, the quota apps field names match real CF (per_process_memory_in_mb / per_app_tasks), and empty spaces relationships are omitted on create. Jetstream: delete handlers discard the job for now (UI contract stays 204-on-accepted), read mappers use the corrected accessors, and test mocks simulate real CF payload field names. Frontend: quota wire bodies send the correct field names. Stratos's own outward API field names are unchanged. Verified end to end against a real CF through make dev: org and space quota create (201) and delete (204) through the UI.
replace fivetwenty-io/capi/v3 with norman-abramovitz/fw-capi/v3 at v3.216.7-quota-fixes.1 (fork main after PR #1: async-delete job refs, quota apps field names, optional spaces relationship). Same /v3-suffix replace pattern used for the earlier delete-wave fixes; drop the directive when the fixes land upstream in a tagged fivetwenty-io release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts three CF v3 contract fixes from fw-capi (norman-abramovitz/fw-capi#1,
merged), found by a docs-contract audit and verified live against a real CF
through
make dev:handlers updated for the new
(*Job, error)signature; the UI contractstays 204-on-accepted for now (surfacing job progress is a follow-up).
per_process_memory_in_mb/per_app_tasks; the previous names(
total_instance_memory_in_mb/total_app_tasks) don't exist in theAPI, so quota create/update from the UI always failed with 422 and the
per-process/tasks limits read back as Unlimited. Frontend wire bodies,
jetstream accessors, and test mocks (which simulated the same wrong
names) all corrected.
relationship (fw-capi side; no Stratos code change needed beyond the
version bump).
go.mod pins
fivetwenty-io/capi/v3to the fork tagnorman-abramovitz/fw-capi/v3 v3.216.7-quota-fixes.1via the same/v3-suffix replace pattern used for the earlier delete-wave fixes;drop the directive when the fixes land in a tagged upstream release.
Testing
go build ./...and the cloudfoundry plugin suite pass against thepublished fork tag (no local overrides)
and delete (204); space quota create (201) and delete (204) — both
delete jobs observed via the Location header
further latent field-name discrepancies in the plugin test fixtures