Bulk route delete/unmap + bulk Manage Roles, single-call per-row Unmap - #5444
Merged
norman-abramovitz merged 4 commits intoJun 13, 2026
Conversation
Option-B bulk model (backend controls fan-out): a bounded bulkFanout
helper (sem-channel, concurrency 6, input-order results, per-item
failures never cancel siblings) + a BulkResult/BulkItemResult envelope.
Three handlers on the routes resource:
POST /cf/routes/{cnsi}/bulk/delete — N DELETEs, each via the
existing RunFastPath job contract (COMPLETE/FAILED/PENDING per item)
POST /cf/routes/{cnsi}/bulk/unmap — atomic PATCH destinations:[] per
route
POST /cf/routes/{cnsi}/{route}/unmap_all — single-route atomic unmap
(backs the per-row Unmap optimization)
Validates empty / >100 guids → 400. Wire-level tests cover happy path,
partial failure, unmap bodies, and validation.
CF and Space Routes tabs gain a checkbox column (with tri-state
select-all across the filtered set) and a bulk-action bar: Unmap
(disabled unless a selected route has bindings) and Delete, each with
a count-aware confirm and partial-failure snackbar reporting. Bulk ops
call the new /bulk/{delete,unmap} endpoints; selection clears after.
Per-row Unmap (unmapAllAppsFromRoute) now issues one atomic
/{route}/unmap_all PATCH instead of fanning out N per-app DELETEs.
Exports SignalListBulkAction from core public-api for consumers.
Each Users tab gains a checkbox column (tri-state select-all across the filtered set) and a bulk Manage Roles action that navigates to the manage-users wizard with ?users=g1,g2,g3 — the multi-user URL the wizard already parses (with single ?user= fallback). Navigation-only, no ngrx dispatch; selection clears on navigate. Scope-correct manage URLs (cf / org / space segments). Specs updated for the leading checkbox column header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the V2-era bulk (multi-select) list actions lost in the signal-native migration, on the Routes and Users tabs. Architecture: Option B (backend controls fan-out). Builds on the now-shipped signal-list checkbox-column + bulk-action-bar framework slot.
Backend — bulk fan-out infrastructure
bulkFanouthelper: bounded (concurrency 6), input-order results, per-item failures never cancel siblings;BulkResult/BulkItemResultenvelope (per-item COMPLETE/FAILED/PENDING).POST /pp/v1/cf/routes/{cnsi}/bulk/delete— N route DELETEs, each through the existingRunFastPathjob contract.POST /pp/v1/cf/routes/{cnsi}/bulk/unmap— atomicPATCH destinations:[]per route.POST /pp/v1/cf/routes/{cnsi}/{route}/unmap_all— single-route atomic unmap (backs the per-row optimization).Frontend — Routes tabs (CF + Space)
unmapAllAppsFromRoutenow issues one atomicunmap_allPATCH instead of N per-app DELETEs.Frontend — Users tabs (CF + Org + Space)
?users=g1,g2,g3— the multi-user URL the wizard already parsed (single?user=fallback intact). Navigation-only, no ngrx. Bulk Remove intentionally omitted (verified never existed in V2; net-new affordance, deferred).Verification
Deferred per plan: the eight V3 bulk-add surfaces (quota→orgs, iso-seg→orgs, etc.) and bulk Remove on Users.