Adopt go1.26 across CI and formatting - #5465
Merged
norman-abramovitz merged 2 commits intoJun 17, 2026
Merged
Conversation
go.mod declares go 1.26.3, but api/structs.go (struct field alignment) and plugins/cfapppush/vcs.go (standalone comment) still carried go1.25 gofmt output. Whitespace and comment only, no behavior change.
go.mod declares go 1.26.3 but CI ran older toolchains (pr + backend tests on 1.25, release on 1.21). Align all three workflows to 1.26 so CI matches the module's required version and its gofmt baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the repo on the Go version
go.modalready declares (go 1.26.3).Changes
pr.ymlandbackend_tests.yml(were 1.25) andrelease.yml(was 1.21).go.modrequires1.26.3, so the older pins were inconsistent with the module's minimum — release at 1.21 was either failing the version requirement or silently auto-downloading 1.26.api/structs.go(struct field alignment) andplugins/cfapppush/vcs.go(standalone comment). Whitespace and comment only, no behavior change. The rest of the backend tree was already 1.26-clean.No functional code changes.