Show busy spinners for Service Keys page operations - #5470
Merged
norman-abramovitz merged 1 commit intoJun 17, 2026
Merged
Conversation
The Service Keys page surfaced its busy states as text only ('Loading…',
'Creating…', 'Deleting…'). On a slow async-job create that read as an
unresponsive page. Add an animate-spin indicator to every busy state — list
load, credential load, create, and delete — each inheriting the surrounding
text colour via border-current. Adds the component's first unit spec covering
all four states.
CF service keys have no update/edit operation (create/view/delete only), so
there is no edit spinner.
norman-abramovitz
approved these changes
Jun 17, 2026
norman-abramovitz
left a comment
norman-abramovitz
left a comment
Contributor
There was a problem hiding this comment.
LGTM and Live verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Service Keys page, every busy state surfaced as text only — "Loading
service keys…", "Creating…", "Deleting…". On a slow async-job create that reads
as an unresponsive page (you click Create, nothing visibly happens for a while).
Fix
Add an
animate-spinindicator to all four busy states so each reads as busy:Each spinner inherits the surrounding text colour via
border-current(muted onthe load messages, white on the primary Create button, danger on Delete), so it
matches its context. Display-only — the async-job flow is unchanged.
CF service keys have no update/edit operation (create / view-credentials /
delete only), so there is no edit spinner.
Tests
Adds the component's first unit spec, covering all four states (each asserts the
spinner appears only while its flag is set). Verified live in a running dev
instance: create shows "Creating…" with the spinner, and delete cleans up.
Full
make check gategreen (592 frontend test files, production build).