CF Users: selection-driven action bar (Manage Roles + Remove) across CF/org/space pages - #5475
Merged
norman-abramovitz merged 14 commits intoJun 20, 2026
Conversation
Always-visible action bar on the Total Users line via the extended
ListSubNavComponent: blue primary Manage Roles + red destructive
Remove from Spaces / Remove from Org and Spaces, disabled-until-valid
(selection + permission + role-presence) with help tooltips, plus a
'N selected / Clear' affordance. Retires the per-row kebab. Removal
fans out via the existing signal-native executeChanges endpoint.
Signals use field initializers (canManageRoles/selectedUsers/
subNavActions/selectedCount), not the (this as {Public}).private cast
that fails the production tsc build — which also corrects a latent
Phase-1 canManageRoles prod-build break.
norman-abramovitz
approved these changes
Jun 20, 2026
norman-abramovitz
left a comment
norman-abramovitz
left a comment
Contributor
There was a problem hiding this comment.
Second cleanup roles interface. Still want to add the missing V3 roles and continue working on a cleaner-looking interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a selection-driven action bar to the three Cloud Foundry Users pages (CF-level, org, space), replacing the per-row kebab for role management and removal.
What changed
POST /pp/v1/cf/roles/:cnsi/changes) withadd:falsechanges; per-change failures and changes skipped for lack of permission are surfaced to the user.ListSubNavComponentwith selection-aware action buttons (primary/destructive/disabled variants). Backward-compatible with existing consumers.Notes
(this as { ... }).privateFieldcast oncanManageRolesthat compiles under vitest but fails the Angular compiler. Converted to field initializers.Testing
ListSubNavComponentextension, and each of the three page components.